Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2023-04-25-preview #23732

Merged
merged 28 commits into from
Jun 1, 2023
Merged

[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2023-04-25-preview #23732

merged 28 commits into from
Jun 1, 2023

Conversation

vedkale
Copy link
Member

@vedkale vedkale commented Apr 26, 2023 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @vedkale Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 26, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    HybridCompute.json 2023-04-25-preview(22fa227) 2022-12-27(main)
    HybridCompute.json 2023-04-25-preview(22fa227) 2023-03-15-preview(main)
    privateLinkScopes.json 2023-04-25-preview(22fa227) 2022-12-27(main)
    privateLinkScopes.json 2023-04-25-preview(22fa227) 2023-03-15-preview(main)
    ️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
    ️⚠️LintDiff: 9 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-preview-2023-04 package-preview-2023-04(22fa227) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L271
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L334
    ⚠️ XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L1382    		 RPC-Async-V1-06
    ⚠️ ProvisioningStateSpecifiedForLRODelete 200 response schema in long running DELETE operation is missing ProvisioningState property. A LRO DELETE operations 200 response schema must have ProvisioningState specified.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L1487
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L2695
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L2900
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L2989
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L3130
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L3207


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Machines_CreateOrUpdate' Request Model: 'parameters[4].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L38
    ❌ PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L74
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L203
    ❌ ResourceNameRestriction The resource name parameter 'extensionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L475
    ❌ ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L476
    ❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'MachineExtensions_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L476
    ❌ PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L519
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L526
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L625
    ❌ LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L813
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L813
    ❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L989
    ❌ OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L1026
    ❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L1077
    ❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'Machine' has extra properties ['resources'].
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L2175
    ❌ ArmResourcePropertiesBag Top level property names should not be repeated inside the properties bag for ARM resource 'MachineExtension'. Properties [properties.type] conflict with ARM top level properties. Please rename these.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json#L2282
    ❌ ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L115
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L116
    ❌ ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L311
    ❌ ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L356
    ❌ ResourceNameRestriction The resource name parameter 'groupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L356
    ❌ ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L401
    ❌ ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L401
    ❌ ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L449
    ❌ PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L484
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L491
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L508
    ❌ ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L575
    ❌ PathForNestedResource The path for nested resource doest not meet the valid resource pattern.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L659
    ❌ ResourceNameRestriction The resource name parameter 'machineName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-04-25-preview/privateLinkScopes.json#L659
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 55 Errors, 0 Warnings failed [Detail]

    Tag package-preview-2023-04; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 41, untested: 0, failed: 32, passed: 9

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: Machines_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: code
    Source: response
    OperationId: Machines_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: message
    Source: response
    OperationId: Machines_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: target
    Source: response
    OperationId: Machines_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/machines/machinenacklss' under resource group 'apiTest-GwiSMN-23732' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Machines_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: PatchResourceNotFound,
    errorMessage: The resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-GwiSMN-23732/providers/Microsoft.HybridCompute/machines/machinenacklss' was not found when evaluating policies for a PATCH operation.
    Source: runtime
    OperationId: Machines_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'nametolr7j' not found.
    Source: runtime
    OperationId: Machines_InstallPatches
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'nametolr7j' not found.
    Source: runtime
    OperationId: Machines_AssessPatches
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: PrivateLinkScopes_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: code
    Source: response
    OperationId: PrivateLinkScopes_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: message
    Source: response
    OperationId: PrivateLinkScopes_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: target
    Source: response
    OperationId: PrivateLinkScopes_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: PrivateLinkScopes_GetValidationDetails
    ❌ INVALID_CONTENT_TYPE Invalid Content-Type (application/problem+json). These are supported: application/json
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: type
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: title
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: status
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: traceId
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: errors
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'machinenacklss' not found.
    Source: runtime
    OperationId: PrivateLinkScopes_GetValidationDetailsForMachine
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/privateLinkScopes/scopenamn1s2wv' under resource group 'apiTest-GwiSMN-23732' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: PrivateLinkScopes_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/privateLinkScopes/scopenamn1s2wv' under resource group 'apiTest-GwiSMN-23732' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: PrivateLinkScopes_UpdateTags
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'machinenacklss' not found.
    Source: runtime
    OperationId: MachineExtensions_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'machinenacklss' not found.
    Source: runtime
    OperationId: MachineExtensions_List
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/machines/machinenacklss/extensions/extensioz4hv5f' under resource group 'apiTest-GwiSMN-23732' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MachineExtensions_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/machines/machinenacklss/extensions/extensioz4hv5f' under resource group 'apiTest-GwiSMN-23732' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MachineExtensions_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/machines/machinenacklss' under resource group 'apiTest-GwiSMN-23732' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MachineRunCommands_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/machines/machinenacklss' under resource group 'apiTest-GwiSMN-23732' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MachineRunCommands_List
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/machines/machinenacklss' under resource group 'apiTest-GwiSMN-23732' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MachineRunCommands_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/machines/machinenacklss' under resource group 'apiTest-GwiSMN-23732' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MachineRunCommands_Update
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the ArcReview label Apr 26, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 26, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/hybridcompute/armhybridcompute - 2.0.0-beta.1
    +	Type of `MachineExtensionProperties.ProtectedSettings` has been changed from `any` to `map[string]any`
+	Type of `MachineExtensionProperties.Settings` has been changed from `any` to `map[string]any`
+	Type of `MachineExtensionUpdateProperties.ProtectedSettings` has been changed from `any` to `map[string]any`
+	Type of `MachineExtensionUpdateProperties.Settings` has been changed from `any` to `map[string]any`
    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-hybridcompute - Approved - 8.0.0
    +	Model Machine no longer has parameter properties
+	Model MachineExtension no longer has parameter properties
+	Model MachineExtensionUpdate no longer has parameter properties
+	Model MachineUpdate no longer has parameter properties
    ❌azure-sdk-for-js - @azure/arm-hybridcompute - Approved - 4.0.0-beta.1
    +	Interface MachineExtensionsListNextOptionalParams no longer has parameter expand
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • ❌Failed [Logs]Release - Generate from 1488328. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • ❌Azure.ResourceManager.HybridCompute [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1488328. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-hybridcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation MachinesOperations.begin_assess_patches
info	[Changelog]   - Added operation MachinesOperations.begin_install_patches
info	[Changelog]   - Added operation group AgentVersionOperations
info	[Changelog]   - Added operation group ExtensionMetadataOperations
info	[Changelog]   - Added operation group HybridIdentityMetadataOperations
info	[Changelog]   - Added operation group MachineRunCommandsOperations
info	[Changelog]   - Added operation group NetworkProfileOperations
info	[Changelog]   - Model AgentConfiguration has a new parameter config_mode
info	[Changelog]   - Model Machine has a new parameter ad_fqdn
info	[Changelog]   - Model Machine has a new parameter agent_configuration
info	[Changelog]   - Model Machine has a new parameter agent_upgrade
info	[Changelog]   - Model Machine has a new parameter agent_version
info	[Changelog]   - Model Machine has a new parameter client_public_key
info	[Changelog]   - Model Machine has a new parameter cloud_metadata
info	[Changelog]   - Model Machine has a new parameter detected_properties
info	[Changelog]   - Model Machine has a new parameter display_name
info	[Changelog]   - Model Machine has a new parameter dns_fqdn
info	[Changelog]   - Model Machine has a new parameter domain_name
info	[Changelog]   - Model Machine has a new parameter error_details
info	[Changelog]   - Model Machine has a new parameter extensions
info	[Changelog]   - Model Machine has a new parameter kind
info	[Changelog]   - Model Machine has a new parameter last_status_change
info	[Changelog]   - Model Machine has a new parameter location_data
info	[Changelog]   - Model Machine has a new parameter machine_fqdn
info	[Changelog]   - Model Machine has a new parameter mssql_discovered
info	[Changelog]   - Model Machine has a new parameter network_profile
info	[Changelog]   - Model Machine has a new parameter os_name
info	[Changelog]   - Model Machine has a new parameter os_profile
info	[Changelog]   - Model Machine has a new parameter os_sku
info	[Changelog]   - Model Machine has a new parameter os_type
info	[Changelog]   - Model Machine has a new parameter os_version
info	[Changelog]   - Model Machine has a new parameter parent_cluster_resource_id
info	[Changelog]   - Model Machine has a new parameter private_link_scope_resource_id
info	[Changelog]   - Model Machine has a new parameter provisioning_state
info	[Changelog]   - Model Machine has a new parameter resources
info	[Changelog]   - Model Machine has a new parameter service_statuses
info	[Changelog]   - Model Machine has a new parameter status
info	[Changelog]   - Model Machine has a new parameter vm_id
info	[Changelog]   - Model Machine has a new parameter vm_uuid
info	[Changelog]   - Model MachineExtension has a new parameter auto_upgrade_minor_version
info	[Changelog]   - Model MachineExtension has a new parameter enable_automatic_upgrade
info	[Changelog]   - Model MachineExtension has a new parameter force_update_tag
info	[Changelog]   - Model MachineExtension has a new parameter instance_view
info	[Changelog]   - Model MachineExtension has a new parameter protected_settings
info	[Changelog]   - Model MachineExtension has a new parameter provisioning_state
info	[Changelog]   - Model MachineExtension has a new parameter publisher
info	[Changelog]   - Model MachineExtension has a new parameter settings
info	[Changelog]   - Model MachineExtension has a new parameter type_handler_version
info	[Changelog]   - Model MachineExtension has a new parameter type_properties_type
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter auto_upgrade_minor_version
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter enable_automatic_upgrade
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter force_update_tag
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter protected_settings
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter publisher
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter settings
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter type
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter type_handler_version
info	[Changelog]   - Model MachineUpdate has a new parameter agent_upgrade
info	[Changelog]   - Model MachineUpdate has a new parameter cloud_metadata
info	[Changelog]   - Model MachineUpdate has a new parameter kind
info	[Changelog]   - Model MachineUpdate has a new parameter location_data
info	[Changelog]   - Model MachineUpdate has a new parameter os_profile
info	[Changelog]   - Model MachineUpdate has a new parameter parent_cluster_resource_id
info	[Changelog]   - Model MachineUpdate has a new parameter private_link_scope_resource_id
info	[Changelog]   - Model ProxyResource has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model TrackedResource has a new parameter system_data
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model Machine no longer has parameter properties
info	[Changelog]   - Model MachineExtension no longer has parameter properties
info	[Changelog]   - Model MachineExtensionUpdate no longer has parameter properties
info	[Changelog]   - Model MachineUpdate no longer has parameter properties
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1488328. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-hybridcompute [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1488328. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/hybridcompute/armhybridcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `MachineExtensionProperties.ProtectedSettings` has been changed from `any` to `map[string]any`
info	[Changelog] - Type of `MachineExtensionProperties.Settings` has been changed from `any` to `map[string]any`
info	[Changelog] - Type of `MachineExtensionUpdateProperties.ProtectedSettings` has been changed from `any` to `map[string]any`
info	[Changelog] - Type of `MachineExtensionUpdateProperties.Settings` has been changed from `any` to `map[string]any`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `AgentConfigurationMode` with values `AgentConfigurationModeFull`, `AgentConfigurationModeMonitor`
info	[Changelog] - New enum type `LastAttemptStatusEnum` with values `LastAttemptStatusEnumFailed`, `LastAttemptStatusEnumSuccess`
info	[Changelog] - New enum type `OsType` with values `OsTypeLinux`, `OsTypeWindows`
info	[Changelog] - New enum type `PatchOperationStartedBy` with values `PatchOperationStartedByPlatform`, `PatchOperationStartedByUser`
info	[Changelog] - New enum type `PatchOperationStatus` with values `PatchOperationStatusCompletedWithWarnings`, `PatchOperationStatusFailed`, `PatchOperationStatusInProgress`, `PatchOperationStatusSucceeded`, `PatchOperationStatusUnknown`
info	[Changelog] - New enum type `PatchServiceUsed` with values `PatchServiceUsedAPT`, `PatchServiceUsedUnknown`, `PatchServiceUsedWU`, `PatchServiceUsedWUWSUS`, `PatchServiceUsedYUM`, `PatchServiceUsedZypper`
info	[Changelog] - New enum type `PrivateCloudKind` with values `PrivateCloudKindAVS`, `PrivateCloudKindHCI`, `PrivateCloudKindSCVMM`, `PrivateCloudKindVMware`
info	[Changelog] - New enum type `VMGuestPatchClassificationLinux` with values `VMGuestPatchClassificationLinuxCritical`, `VMGuestPatchClassificationLinuxOther`, `VMGuestPatchClassificationLinuxSecurity`
info	[Changelog] - New enum type `VMGuestPatchClassificationWindows` with values `VMGuestPatchClassificationWindowsCritical`, `VMGuestPatchClassificationWindowsDefinition`, `VMGuestPatchClassificationWindowsFeaturePack`, `VMGuestPatchClassificationWindowsSecurity`, `VMGuestPatchClassificationWindowsServicePack`, `VMGuestPatchClassificationWindowsTools`, `VMGuestPatchClassificationWindowsUpdateRollUp`, `VMGuestPatchClassificationWindowsUpdates`
info	[Changelog] - New enum type `VMGuestPatchRebootSetting` with values `VMGuestPatchRebootSettingAlways`, `VMGuestPatchRebootSettingIfRequired`, `VMGuestPatchRebootSettingNever`
info	[Changelog] - New enum type `VMGuestPatchRebootStatus` with values `VMGuestPatchRebootStatusCompleted`, `VMGuestPatchRebootStatusFailed`, `VMGuestPatchRebootStatusNotNeeded`, `VMGuestPatchRebootStatusRequired`, `VMGuestPatchRebootStatusStarted`, `VMGuestPatchRebootStatusUnknown`
info	[Changelog] - New function `NewAgentVersionClient(azcore.TokenCredential, *arm.ClientOptions) (*AgentVersionClient, error)`
info	[Changelog] - New function `*AgentVersionClient.Get(context.Context, string, string, *AgentVersionClientGetOptions) (AgentVersionClientGetResponse, error)`
info	[Changelog] - New function `*AgentVersionClient.List(context.Context, string, *AgentVersionClientListOptions) (AgentVersionClientListResponse, error)`
info	[Changelog] - New function `*ClientFactory.NewAgentVersionClient() *AgentVersionClient`
info	[Changelog] - New function `*ClientFactory.NewExtensionMetadataClient() *ExtensionMetadataClient`
info	[Changelog] - New function `*ClientFactory.NewHybridIdentityMetadataClient() *HybridIdentityMetadataClient`
info	[Changelog] - New function `*ClientFactory.NewMachineRunCommandsClient() *MachineRunCommandsClient`
info	[Changelog] - New function `*ClientFactory.NewNetworkProfileClient() *NetworkProfileClient`
info	[Changelog] - New function `NewExtensionMetadataClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ExtensionMetadataClient, error)`
info	[Changelog] - New function `*ExtensionMetadataClient.Get(context.Context, string, string, string, string, *ExtensionMetadataClientGetOptions) (ExtensionMetadataClientGetResponse, error)`
info	[Changelog] - New function `*ExtensionMetadataClient.NewListPager(string, string, string, *ExtensionMetadataClientListOptions) *runtime.Pager[ExtensionMetadataClientListResponse]`
info	[Changelog] - New function `NewHybridIdentityMetadataClient(string, azcore.TokenCredential, *arm.ClientOptions) (*HybridIdentityMetadataClient, error)`
info	[Changelog] - New function `*HybridIdentityMetadataClient.Get(context.Context, string, string, string, *HybridIdentityMetadataClientGetOptions) (HybridIdentityMetadataClientGetResponse, error)`
info	[Changelog] - New function `*HybridIdentityMetadataClient.NewListByMachinesPager(string, string, *HybridIdentityMetadataClientListByMachinesOptions) *runtime.Pager[HybridIdentityMetadataClientListByMachinesResponse]`
info	[Changelog] - New function `NewMachineRunCommandsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*MachineRunCommandsClient, error)`
info	[Changelog] - New function `*MachineRunCommandsClient.BeginCreateOrUpdate(context.Context, string, string, string, MachineRunCommand, *MachineRunCommandsClientBeginCreateOrUpdateOptions) (*runtime.Poller[MachineRunCommandsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*MachineRunCommandsClient.BeginDelete(context.Context, string, string, string, *MachineRunCommandsClientBeginDeleteOptions) (*runtime.Poller[MachineRunCommandsClientDeleteResponse], error)`
info	[Changelog] - New function `*MachineRunCommandsClient.Get(context.Context, string, string, string, *MachineRunCommandsClientGetOptions) (MachineRunCommandsClientGetResponse, error)`
info	[Changelog] - New function `*MachineRunCommandsClient.NewListPager(string, string, *MachineRunCommandsClientListOptions) *runtime.Pager[MachineRunCommandsClientListResponse]`
info	[Changelog] - New function `*MachineRunCommandsClient.BeginUpdate(context.Context, string, string, string, MachineRunCommandUpdate, *MachineRunCommandsClientBeginUpdateOptions) (*runtime.Poller[MachineRunCommandsClientUpdateResponse], error)`
info	[Changelog] - New function `*MachinesClient.BeginAssessPatches(context.Context, string, string, *MachinesClientBeginAssessPatchesOptions) (*runtime.Poller[MachinesClientAssessPatchesResponse], error)`
info	[Changelog] - New function `*MachinesClient.BeginInstallPatches(context.Context, string, string, MachineInstallPatchesParameters, *MachinesClientBeginInstallPatchesOptions) (*runtime.Poller[MachinesClientInstallPatchesResponse], error)`
info	[Changelog] - New function `NewNetworkProfileClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkProfileClient, error)`
info	[Changelog] - New function `*NetworkProfileClient.Get(context.Context, string, string, *NetworkProfileClientGetOptions) (NetworkProfileClientGetResponse, error)`
info	[Changelog] - New struct `AgentUpgrade`
info	[Changelog] - New struct `AgentVersion`
info	[Changelog] - New struct `AgentVersionsList`
info	[Changelog] - New struct `AvailablePatchCountByClassification`
info	[Changelog] - New struct `ErrorDetailAutoGenerated`
info	[Changelog] - New struct `ErrorResponseAutoGenerated`
info	[Changelog] - New struct `ExtensionValue`
info	[Changelog] - New struct `ExtensionValueListResult`
info	[Changelog] - New struct `ExtensionValueProperties`
info	[Changelog] - New struct `HybridIdentityMetadata`
info	[Changelog] - New struct `HybridIdentityMetadataList`
info	[Changelog] - New struct `HybridIdentityMetadataProperties`
info	[Changelog] - New struct `IPAddress`
info	[Changelog] - New struct `LinuxParameters`
info	[Changelog] - New struct `MachineAssessPatchesResult`
info	[Changelog] - New struct `MachineInstallPatchesParameters`
info	[Changelog] - New struct `MachineInstallPatchesResult`
info	[Changelog] - New struct `MachineRunCommand`
info	[Changelog] - New struct `MachineRunCommandInstanceView`
info	[Changelog] - New struct `MachineRunCommandInstanceViewStatus`
info	[Changelog] - New struct `MachineRunCommandProperties`
info	[Changelog] - New struct `MachineRunCommandScriptSource`
info	[Changelog] - New struct `MachineRunCommandUpdate`
info	[Changelog] - New struct `MachineRunCommandsListResult`
info	[Changelog] - New struct `NetworkInterface`
info	[Changelog] - New struct `NetworkProfile`
info	[Changelog] - New struct `RunCommandInputParameter`
info	[Changelog] - New struct `RunCommandManagedIdentity`
info	[Changelog] - New struct `Subnet`
info	[Changelog] - New struct `WindowsParameters`
info	[Changelog] - New field `ConfigMode` in struct `AgentConfiguration`
info	[Changelog] - New field `Kind`, `Resources` in struct `Machine`
info	[Changelog] - New field `EnableAutomaticUpgrade` in struct `MachineExtensionUpdateProperties`
info	[Changelog] - New field `AgentUpgrade`, `NetworkProfile` in struct `MachineProperties`
info	[Changelog] - New field `Kind` in struct `MachineUpdate`
info	[Changelog] - New field `AgentUpgrade` in struct `MachineUpdateProperties`
info	[Changelog] - New field `SystemData` in struct `ProxyResource`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New field `SystemData` in struct `TrackedResource`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 147 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1488328. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-hybridcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface AgentVersion
info	[Changelog]   - Added Interface AgentVersionGetOptionalParams
info	[Changelog]   - Added Interface AgentVersionListOptionalParams
info	[Changelog]   - Added Interface AgentVersionsList
info	[Changelog]   - Added Interface AvailablePatchCountByClassification
info	[Changelog]   - Added Interface CloudMetadata
info	[Changelog]   - Added Interface ConfigurationExtension
info	[Changelog]   - Added Interface ErrorDetailAutoGenerated
info	[Changelog]   - Added Interface ErrorResponseAutoGenerated
info	[Changelog]   - Added Interface ExtensionMetadataGetOptionalParams
info	[Changelog]   - Added Interface ExtensionMetadataListOptionalParams
info	[Changelog]   - Added Interface ExtensionValue
info	[Changelog]   - Added Interface ExtensionValueListResult
info	[Changelog]   - Added Interface HybridComputeManagementClientUpgradeExtensionsHeaders
info	[Changelog]   - Added Interface HybridComputePrivateLinkScope
info	[Changelog]   - Added Interface HybridIdentityMetadata
info	[Changelog]   - Added Interface HybridIdentityMetadataGetOptionalParams
info	[Changelog]   - Added Interface HybridIdentityMetadataList
info	[Changelog]   - Added Interface HybridIdentityMetadataListByMachinesNextOptionalParams
info	[Changelog]   - Added Interface HybridIdentityMetadataListByMachinesOptionalParams
info	[Changelog]   - Added Interface IpAddress
info	[Changelog]   - Added Interface LinuxParameters
info	[Changelog]   - Added Interface Machine
info	[Changelog]   - Added Interface MachineAssessPatchesResult
info	[Changelog]   - Added Interface MachineExtension
info	[Changelog]   - Added Interface MachineExtensionsDeleteHeaders
info	[Changelog]   - Added Interface MachineExtensionsUpdateHeaders
info	[Changelog]   - Added Interface MachineExtensionUpdate
info	[Changelog]   - Added Interface MachineInstallPatchesParameters
info	[Changelog]   - Added Interface MachineInstallPatchesResult
info	[Changelog]   - Added Interface MachineRunCommand
info	[Changelog]   - Added Interface MachineRunCommandInstanceView
info	[Changelog]   - Added Interface MachineRunCommandInstanceViewStatus
info	[Changelog]   - Added Interface MachineRunCommandsCreateOrUpdateHeaders
info	[Changelog]   - Added Interface MachineRunCommandsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface MachineRunCommandScriptSource
info	[Changelog]   - Added Interface MachineRunCommandsDeleteHeaders
info	[Changelog]   - Added Interface MachineRunCommandsDeleteOptionalParams
info	[Changelog]   - Added Interface MachineRunCommandsGetOptionalParams
info	[Changelog]   - Added Interface MachineRunCommandsListNextOptionalParams
info	[Changelog]   - Added Interface MachineRunCommandsListOptionalParams
info	[Changelog]   - Added Interface MachineRunCommandsListResult
info	[Changelog]   - Added Interface MachineRunCommandsUpdateHeaders
info	[Changelog]   - Added Interface MachineRunCommandsUpdateOptionalParams
info	[Changelog]   - Added Interface MachineRunCommandUpdate
info	[Changelog]   - Added Interface MachinesAssessPatchesHeaders
info	[Changelog]   - Added Interface MachinesAssessPatchesOptionalParams
info	[Changelog]   - Added Interface MachinesInstallPatchesHeaders
info	[Changelog]   - Added Interface MachinesInstallPatchesOptionalParams
info	[Changelog]   - Added Interface MachineUpdate
info	[Changelog]   - Added Interface NetworkInterface
info	[Changelog]   - Added Interface NetworkProfile
info	[Changelog]   - Added Interface NetworkProfileGetOptionalParams
info	[Changelog]   - Added Interface OSProfileLinuxConfiguration
info	[Changelog]   - Added Interface OSProfileWindowsConfiguration
info	[Changelog]   - Added Interface PrivateEndpointConnection
info	[Changelog]   - Added Interface PrivateEndpointConnectionDataModel
info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteHeaders
info	[Changelog]   - Added Interface PrivateLinkResource
info	[Changelog]   - Added Interface PrivateLinkScopesDeleteHeaders
info	[Changelog]   - Added Interface ProxyResource
info	[Changelog]   - Added Interface RunCommandInputParameter
info	[Changelog]   - Added Interface RunCommandManagedIdentity
info	[Changelog]   - Added Interface ServiceStatus
info	[Changelog]   - Added Interface ServiceStatuses
info	[Changelog]   - Added Interface Subnet
info	[Changelog]   - Added Interface TrackedResource
info	[Changelog]   - Added Interface WindowsParameters
info	[Changelog]   - Added Type Alias AgentConfigurationMode
info	[Changelog]   - Added Type Alias AgentVersionGetResponse
info	[Changelog]   - Added Type Alias AgentVersionListResponse
info	[Changelog]   - Added Type Alias AssessmentModeTypes
info	[Changelog]   - Added Type Alias ExtensionMetadataGetResponse
info	[Changelog]   - Added Type Alias ExtensionMetadataListResponse
info	[Changelog]   - Added Type Alias HybridIdentityMetadataGetResponse
info	[Changelog]   - Added Type Alias HybridIdentityMetadataListByMachinesNextResponse
info	[Changelog]   - Added Type Alias HybridIdentityMetadataListByMachinesResponse
info	[Changelog]   - Added Type Alias LastAttemptStatusEnum
info	[Changelog]   - Added Type Alias MachineRunCommandsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias MachineRunCommandsGetResponse
info	[Changelog]   - Added Type Alias MachineRunCommandsListNextResponse
info	[Changelog]   - Added Type Alias MachineRunCommandsListResponse
info	[Changelog]   - Added Type Alias MachineRunCommandsUpdateResponse
info	[Changelog]   - Added Type Alias MachinesAssessPatchesResponse
info	[Changelog]   - Added Type Alias MachinesInstallPatchesResponse
info	[Changelog]   - Added Type Alias NetworkProfileGetResponse
info	[Changelog]   - Added Type Alias OsType
info	[Changelog]   - Added Type Alias PatchModeTypes
info	[Changelog]   - Added Type Alias PatchOperationStartedBy
info	[Changelog]   - Added Type Alias PatchOperationStatus
info	[Changelog]   - Added Type Alias PatchServiceUsed
info	[Changelog]   - Added Type Alias PrivateCloudKind
info	[Changelog]   - Added Type Alias VMGuestPatchClassificationLinux
info	[Changelog]   - Added Type Alias VMGuestPatchClassificationWindows
info	[Changelog]   - Added Type Alias VMGuestPatchRebootSetting
info	[Changelog]   - Added Type Alias VMGuestPatchRebootStatus
info	[Changelog]   - Interface HybridComputePrivateLinkScopeProperties has a new optional parameter privateEndpointConnections
info	[Changelog]   - Interface OperationValue has a new optional parameter isDataAction
info	[Changelog]   - Interface OSProfile has a new optional parameter linuxConfiguration
info	[Changelog]   - Interface OSProfile has a new optional parameter windowsConfiguration
info	[Changelog]   - Interface PrivateEndpointConnectionProperties has a new optional parameter groupIds
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Added Enum KnownAgentConfigurationMode
info	[Changelog]   - Added Enum KnownAssessmentModeTypes
info	[Changelog]   - Added Enum KnownLastAttemptStatusEnum
info	[Changelog]   - Added Enum KnownOsType
info	[Changelog]   - Added Enum KnownPatchModeTypes
info	[Changelog]   - Added Enum KnownPatchOperationStartedBy
info	[Changelog]   - Added Enum KnownPatchOperationStatus
info	[Changelog]   - Added Enum KnownPatchServiceUsed
info	[Changelog]   - Added Enum KnownPrivateCloudKind
info	[Changelog]   - Added Enum KnownVMGuestPatchClassificationLinux
info	[Changelog]   - Added Enum KnownVMGuestPatchClassificationWindows
info	[Changelog]   - Added Enum KnownVMGuestPatchRebootSetting
info	[Changelog]   - Added Enum KnownVMGuestPatchRebootStatus
info	[Changelog]   - Added function getContinuationToken
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface MachineExtensionsListNextOptionalParams no longer has parameter expand
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1488328. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️hybridcompute [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs]Release - Generate from 1488328. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
    • ❌Az.hybridcompute.DefaultTag [View full logs]  
      error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.hybridcompute.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 26, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/hybridcompute/armhybridcompute https://apiview.dev/Assemblies/Review/9e9015613fb14e5799449a9d4411c0e7
    Java azure-resourcemanager-hybridcompute https://apiview.dev/Assemblies/Review/b94e7f6f70924e02a349902c341a58f4
    JavaScript @azure/arm-hybridcompute https://apiview.dev/Assemblies/Review/90c0d010bcc745a79cfe53850fe911e2

    @openapi-workflow-bot
    Copy link

    Hi @vedkale and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to [email protected].

    This was referenced Apr 26, 2023
    Closed
    Closed
    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version resource-manager labels Apr 26, 2023
    @openapi-workflow-bot
    Copy link

    Hi @vedkale, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @azure-sdk azure-sdk mentioned this pull request Apr 26, 2023
    Closed
    @azure-sdk azure-sdk mentioned this pull request Apr 26, 2023
    Closed
    This was referenced Apr 26, 2023
    Closed
    Closed
    @vedkale vedkale closed this Apr 26, 2023
    @vedkale vedkale reopened this Apr 26, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 10, 2023
    @TimLovellSmith
    Copy link
    Member 

        },

    Are these intended as a write-only property?

    Refers to: specification/hybridcompute/resource-manager/Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json:3129 in c9a4b57. [](commit_id = c9a4b57, deletion_comment = False)

    @TimLovellSmith TimLovellSmith added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 11, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 11, 2023
    @TimLovellSmith
    Copy link
    Member 

        },

    x-ms-mutability: "create, update"?

    Refers to: specification/hybridcompute/resource-manager/Microsoft.HybridCompute/preview/2023-04-25-preview/HybridCompute.json:3143 in c9a4b57. [](commit_id = c9a4b57, deletion_comment = False)

    @justinytchen
    Copy link
    Member

    image
    Looks good, small differences in descriptions of properties compared to Microsoft.Compute, but I'm not sure if these have been accounted for yet.

    @vedkale
    Copy link
    Member Author

    vedkale commented May 24, 2023

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @vedkale
    Copy link
    Member Author

    vedkale commented May 24, 2023

    @Wzb123456789 can I please get a review for this PR? It looks like CredScan is failing but there are no secrets in the example, is that ok?

    @vedkale
    Copy link
    Member Author

    vedkale commented May 30, 2023

    @Wzb123456789 can I please get a review for this PR?

    @Wzb123456789 Wzb123456789 added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 1, 2023
    @raych1
    Copy link
    Member

    raych1 commented Jun 1, 2023

    Go sdk breaking change is false alarm.

    @chunyu3 chunyu3 merged commit 1488328 into main Jun 1, 2023
    @chunyu3 chunyu3 deleted the vedkale-hybridcompute-Microsoft.HybridCompute-2023-04-25-preview branch June 1, 2023 05:29
    This was referenced Jun 1, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @raghushantha
    Copy link
    Contributor

    raghushantha commented Jun 1, 2023 via email

    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    @vedkale @harryli0108
    [Hub Generated] Review request for Microsoft.HybridCompute to add ver…
    d6331b0 
    …sion preview/2023-04-25-preview (Azure#23732)

* Adds base for updating Microsoft.HybridCompute from version preview/2023-03-15-preview to version 2023-04-25-preview

* Updates readme

* Updates API version in new specs and examples

* add run command resource

* fix errors

* fix delete headers and list run command type

* add delete example

* change resource type run command

* merge stable version changes

* fix api version in examples

* add http patch, pattern for machine name

* add 201 to put and update body

* add update example

* add identifiers

* add 201 response and name pattern

* fix staging lint issues

* undo commit

* fix location header

* switch to v3

* change final state via

* add machineNameParamter

* revert change to fix breaking change

* fix tracked resource version for breaking change

* address comments

* address comments

* run prettier

* update description

---------

Co-authored-by: Ved Kale <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @qiaozha qiaozha qiaozha left review comments

    @TimLovellSmith TimLovellSmith TimLovellSmith left review comments

    @raghushantha raghushantha raghushantha approved these changes

    @Wzb123456789 Wzb123456789 Awaiting requested review from Wzb123456789

    Assignees

    @ArcturusZhang ArcturusZhang

    @Wzb123456789 Wzb123456789

    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ArcReview ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.